Re: [gpsd-dev] gpsprof giving some errors

[Nuno Gonçalves]

[PATCH] Fix Append to string of serial parameters

Before it didn't print any serial parameters.

Signed-off-by: Nuno Goncalves <address@hidden>
---
 gpsprof | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gpsprof b/gpsprof
index eac2423..82972e0 100755
--- a/gpsprof
+++ b/gpsprof
@@ -63,7 +63,7 @@ class plotter:
                (gps.misc.isotime(self.start_time),
                 self.device.get('driver', "unknown"))
         if 'bps' in self.device:
-            desc + "%d %dN%d, cycle %ds" % \
+            desc += "%d %dN%d, cycle %ds" % \
                  (self.device['bps'], 9 - self.device['stopbits'],
                   self.device['stopbits'], self.device['cycle'])
         else:
-- 
2.1.4

On Sun, Aug 23, 2015 at 11:18 PM, Eric S. Raymond <address@hidden> wrote:
> Sanjeev Gupta <address@hidden>:
>> > But at http://www.catb.org/gpsd/gpsd_json.html, we see that the DEVICE
>> > object MUST always contain a "parity" and "stopbit" elements. Since
>> > they wouldn't make sense this case should be a documentation error.
>> >
>>
>> Just below the DEVICE spec table, is the line:
>>
>> "The serial parameters will be omitted in a response describing a TCP/IP
>> source such as an Ntrip, DGPSIP, or AIS feed."
>
> Still, it was worded rather confusingly.  I'll commit a fix.
> --
>                 <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>