gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] Bug in JSON encoding AIVDM type 9 messages


From: Jon Schlueter
Subject: Re: [gpsd-dev] Bug in JSON encoding AIVDM type 9 messages
Date: Tue, 6 Oct 2015 05:33:31 -0400

Stefan,

thanks for the sample data! really a great help in making sure we get the fix correct and it stays fixed as we change things.


On Tue, Oct 6, 2015 at 12:37 AM, Stefan Roels <address@hidden> wrote:
Hi Jon,

The airtemp/dewpoint/watertemp patch does not work. Its the substraction that causes the problem, so casting it to float after the substraction is too late.

Thank you for the samples and the patch.  It was a start but there was one other watertemp as well that had same issue.
The following commit fixes up the scaling issue you identified:

http://git.savannah.gnu.org/cgit/gpsd.git/commit/?id=5c20d030c70578d6d212b00cc972e2b19d5abf9c

 

I do also have some examples of the type 8 DAC 1 FID 16 messages that should not be converted. I have no examples of the ones that should, but from the documentation, it seems not sure that they actually exist.

!AIVDM,3,1,0,A,address@hidden@mE8;;address@hidden;gh0w00010Wk3<2FG,0*00
!AIVDM,3,2,0,A,ePm;address@hidden@0w00010W:s02F>,0*72
!AIVDM,3,3,0,A,Ghm4utWw2P,4*27
{"class":"AIS","device":"stdin","type":8,"repeat":0,"mmsi":2711009,"scaled":true,"dac":1,"fid":16,"data":"720:00025e8d136025bd890d5520b2ff0ac000000070202580430d4bbf003f000001027cc3302597b60d4b15003f000000c5c4a9802584cf


Still trying to get this one wrangled into shape and get scons check to pass

https://github.com/yazug/gpsd/commit/25949acc27107aed330ede5d5754b5d646cbe226

scons aivdm-regress is failing both scaled and unscaled


Testing idempotency of unscaled JSON dump/decode for AIS
gpsdecode: dying with status 3 (unknown attribute name) on line 87

-{"class":"AIS","device":"stdin","type":8,"repeat":0,"mmsi":2711009,"scaled":false,"dac":1,"fid":16,"data":"720:00025e8d136025bd890d5520b2ff0ac000000070202580430d4bbf003f000001027cc3302597b60d4b15003f000000c5c4a9802584cf0d3f45803f000000f47ba58025cdf40d4391003f0000010272bb00258e5f0d44f7c9ff0a"}

Eric any thoughts on this aspect of the problem?

Jon

reply via email to

[Prev in Thread] Current Thread [Next in Thread]