[gpsd-dev] Missing TPV when there is no fix

[Piotr Figiel]

Hi,
 on recent gpsd [1] I stumbled on an issue similar to one reported
already in the past [2] that TPV with mode = 1 (MODE_NO_FIX) is not
being sent by the gpsd when the fix is lost. Instead no TPV at all was
received by the clients by the time there was no fix. This affects use
case when it's expected to detect fix loss on libgps client.
 On my receiver (Telit's SL869, but I also remember this appearing in
the past on HE910) the scenario is easily reproducible with cgps:
 - wait for receiver to get fix,
 - run cgps,
 - disconnect antenna,
-> cgps still shows 3D fix despite the RMC sentences (as observed with
gpspipe) show that fix was lost.
I isolated the issue so that it's reproducible with attached log file
used with gpsfake (-c 1) - gpsfake simulates sequence: no fix -> fix
-> no fix -> etc...
I introduced correction which now I'm testing and it resolves the
issue. It's attached, can you please review and merge if applicable?

Best regards,
Piotr Figiel.

[1] confirmed on master, 3db781b747e03df8faa71a8d4281f9294e05084b but
also in past versions
[2] https://lists.gnu.org/archive/html/gpsd-users/2016-11/msg00013.html

RMC2.tmp.log
Description: Text Data

0001-nmea-0183-report-MODE_NO_FIX-when-there-is-no-fix.patch
Description: Text Data