[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] gpsd: skip tcdrain() when closing in readonly mode
From: |
Gary E. Miller |
Subject: |
Re: [gpsd-dev] gpsd: skip tcdrain() when closing in readonly mode |
Date: |
Wed, 2 May 2018 12:04:50 -0700 |
Yo Jean!
On Wed, 2 May 2018 15:05:54 +0000
Jean Pierre TOSONI <address@hidden> wrote:
> > Hanging is caused by the call to tcdrain(), which happens even when
> > gpsd is in read-only mode (-b argument).
> >
> > In this mode, since nothing is ever written to the serial port, the
> > tcdrain call is not needed. Skip it.
Nice patch. Applied to git head.
I have been finding a lot of other issues with the -b lately. Many
pieces of code ignore -b with unexpected results.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1 541 382 8588
Veritas liberabit vos. -- Quid est veritas?
"If you can’t measure it, you can’t improve it." - Lord Kelvin
pgpIyIeRJ8M7i.pgp
Description: OpenPGP digital signature