Re: [PATCH 2/3] Adjust import script, definitions and API users for libgcrypt 1.10

[Daniel Kiper]

Please add a commit message and SOB...

Additionally, please expand "Updating external code" in GRUB dev
documentation with a description how to update libgcrypt.

On Thu, May 16, 2024 at 09:27:42PM +0300, Vladimir Serbinenko wrote:
> ---
>  autogen.sh                                 |   1 +

Should not autogen.sh remove libgcrypt-grub when it exists?
If yes then it should be separate patch.

>  conf/Makefile.common                       |   4 +-
>  grub-core/Makefile.core.def                |  36 +-
>  grub-core/commands/hashsum.c               |   2 +-
>  grub-core/commands/legacycfg.c             |   6 +-
>  grub-core/commands/pgp.c                   | 114 +---
>  grub-core/commands/xnu_uuid.c              |   2 +-
>  grub-core/disk/cryptodisk.c                |   2 +-
>  grub-core/io/gzio.c                        |   2 +-
>  grub-core/io/lzopio.c                      |   2 +-
>  grub-core/lib/adler32.c                    |  21 +-
>  grub-core/lib/b64dec.c                     | 293 +++++++++
>  grub-core/lib/crc64.c                      |  24 +-
>  grub-core/lib/crypto.c                     | 245 +++++++-
>  grub-core/lib/libgcrypt/src/gcrypt-int.h   |  51 --
>  grub-core/lib/libgcrypt_wrap/cipher_wrap.h |  12 +-
>  grub-core/lib/libgcrypt_wrap/md.c          | 687 +++++++++++++++++++++
>  grub-core/lib/libgcrypt_wrap/mem.c         |  83 ++-
>  grub-core/lib/xzembed/xz_dec_stream.c      |  18 +-
>  grub-core/tests/dsa_sexp_test.c            | 107 ++++
>  grub-core/tests/rsa_sexp_test.c            |  81 +++

I would add these tests in separate patches.

>  include/grub/crypto.h                      | 261 ++++++--
>  include/grub/gcrypt/gpg-error.h            |   9 +
>  util/grub-fstest.c                         |   2 +-
>  util/import_gcry.py                        | 122 ++--
>  util/import_gcrypt_inth.sed                |  17 +
>  util/import_gcrypth.sed                    |   2 -
>  27 files changed, 1942 insertions(+), 264 deletions(-)
>  create mode 100644 grub-core/lib/b64dec.c
>  create mode 100644 grub-core/lib/libgcrypt_wrap/md.c
>  create mode 100644 grub-core/tests/dsa_sexp_test.c
>  create mode 100644 grub-core/tests/rsa_sexp_test.c
>  create mode 100644 util/import_gcrypt_inth.sed

Hmmm... Could not we split further this patch set?

Daniel