[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table(
|
From: |
Adam Williamson |
|
Subject: |
Re: [PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table() |
|
Date: |
Wed, 16 Oct 2024 11:51:45 -0700 |
|
User-agent: |
Evolution 3.54.0 (3.54.0-1.fc41) |
On Wed, 2024-10-16 at 16:20 +1100, Benjamin Herrenschmidt wrote:
> The calculation of the size of the table was incorrect (copy/pasta from
> grub_acpi_rsdt_find_table() I assume...). The entries are 64-bit long.
>
> This causes us to access beyond the end of the table which is causing
> crashes during boot on some systems. Typically this is causing a crash
> on VMWare when using UEFI and enabling serial autodetection, as
>
> grub_acpi_find_table (GRUB_ACPI_SPCR_SIGNATURE);
>
> Will goes past the end of the table (the SPCR table doesn't exits)
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This can be marked as:
Tested-by: Renata Ravanelli <rravanel@redhat.com>
per https://bugzilla.redhat.com/show_bug.cgi?id=2317048#c35 .
--
Adam Williamson (he/him/his)
Fedora QA
Fedora Chat: @adamwill:fedora.im | Mastodon: @adamw@fosstodon.org
https://www.happyassassin.net