[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49813] [PATCH 04/34] gnu: tao: Fix regex in FIND-FILES invocation.
From: |
Sarah Morgensen |
Subject: |
[bug#49813] [PATCH 04/34] gnu: tao: Fix regex in FIND-FILES invocation. |
Date: |
Sat, 28 Aug 2021 15:59:32 -0700 |
Hi Maxime,
Thanks for taking a look at this.
Maxime Devos <maximedevos@telenet.be> writes:
> Sarah Morgensen schreef op zo 01-08-2021 om 14:18 [-0700]:
>> - (find-files "include" "\\.h"))
>> + (find-files "include" "\\.h$"))
>
> C++ header files are sometimes named "something.hpp" instead
> of "something.h", so you might want to verify these don't exist.
> (And if they do exist, keep the regex "\\.h", or make it "\\.(h|hpp)$"?)
>
> Likewise for 'kaldi', 'shogun' and 'rtags'. Otherwise, these
> new regexes look good to me (but I didn't test them).
Good catch. I just checked the sources for all of those, and I can
verify that they don't exist. (Shogun and rtags do have .hpp files in
their source, but only in other directories.)
--
Sarah
- [bug#49813] [PATCH 27/34] gnu: john-the-ripper-jumbo: Fix regex in FIND-FILES invocation., (continued)
- [bug#49813] [PATCH 27/34] gnu: john-the-ripper-jumbo: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 26/34] gnu: qtpass: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 28/34] gnu: python-robotframework-sshlibrary: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 24/34] gnu: atlas: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 30/34] gnu: aegis: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 29/34] gnu: python-cram: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 31/34] gnu: bullet: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 34/34] gnu: rtags: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 33/34] gnu: alpine: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 32/34] gnu: shogun: Fix regex in FIND-FILES invocation., Sarah Morgensen, 2021/08/01
- [bug#49813] [PATCH 04/34] gnu: tao: Fix regex in FIND-FILES invocation.,
Sarah Morgensen <=