[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 05/11] gdbstub: add helper for 128 bit registers
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC PATCH 05/11] gdbstub: add helper for 128 bit registers |
|
Date: |
Mon, 18 Nov 2019 09:13:35 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 11/15/19 6:29 PM, Alex Bennée wrote:
> +static inline int gdb_get_reg128(uint8_t *mem_buf, uint64_t val_hi,
> + uint64_t val_lo)
> +{
> + stq_p(mem_buf, val_hi);
> + stq_p(mem_buf + 8, val_lo);
> + return 16;
Since stq_p itself depends on TARGET_WORDS_BIGENDIAN,
I think the word ordering here should as well.
r~
- [RFC PATCH 00/11] gdbstub re-factor and SVE support, Alex Bennée, 2019/11/15
- [RFC PATCH 06/11] target/arm: use gdb_get_reg helpers, Alex Bennée, 2019/11/15
- [RFC PATCH 05/11] gdbstub: add helper for 128 bit registers, Alex Bennée, 2019/11/15
- Re: [RFC PATCH 05/11] gdbstub: add helper for 128 bit registers,
Richard Henderson <=
- [RFC PATCH 04/11] gdbstub: move mem_buf to GDBState and use GByteArray, Alex Bennée, 2019/11/15
- [RFC PATCH 07/11] target/m68k: use gdb_get_reg helpers, Alex Bennée, 2019/11/15
- [RFC PATCH 03/11] gdbstub: move str_buf to GDBState and use GString, Alex Bennée, 2019/11/15
- [RFC PATCH 02/11] gdbstub: stop passing GDBState * around, Alex Bennée, 2019/11/15