qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/7] vhost-user: hoist "write_sync", "get_features", "get_


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 5/7] vhost-user: hoist "write_sync", "get_features", "get_u64"
Date: Wed, 6 Sep 2023 11:59:34 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0

On 31/8/23 09:20, Laszlo Ersek wrote:
On 8/30/23 15:40, Laszlo Ersek wrote:
In order to avoid a forward-declaration for "vhost_user_write_sync" in a
subsequent patch, hoist "vhost_user_write_sync" ->
"vhost_user_get_features" -> "vhost_user_get_u64" just above
"vhost_set_vring".

This is purely code movement -- no observable change.

Cc: "Michael S. Tsirkin" <mst@redhat.com> (supporter:vhost)
Cc: Eugenio Perez Martin <eperezma@redhat.com>
Cc: German Maglione <gmaglione@redhat.com>
Cc: Liu Jiang <gerry@linux.alibaba.com>
Cc: Sergio Lopez Pascual <slp@redhat.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
---

Notes:
     v2:
- pick up R-b from Stefano - rename "vhost_user_write_msg" to "vhost_user_write_sync" (in code and
       commit message) [Stefano]

  hw/virtio/vhost-user.c | 170 ++++++++++----------
  1 file changed, 85 insertions(+), 85 deletions(-)

Phil reviewed v1:

http://mid.mail-archive.com/98150923-39ef-7581-6144-8d0ad8d4dd52@linaro.org

and I would've kept his R-b (similar to Stefano's) across the
vhost_user_write_msg->vhost_user_write_sync rename in v2; so I'm copying
it here:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Hope that's OK.

Sure! (same for patch 2/7)

Thanks :)

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]