Re: [PATCH v3 00/19] crypto: Provide clmul.h and host accel

[Richard Henderson]

Ping.

Still missing r-b on patches 1, 4, 5, 8, 9, 12, 13, 18.

r~

On 8/21/23 09:18, Richard Henderson wrote:
> Inspired by Ard Biesheuvel's RFC patches [1] for accelerating
> carry-less multiply under emulation.
>
> Changes for v3:
>    * Update target/i386 ops_sse.h.
>    * Apply r-b.
>
> Changes for v2:
>    * Only accelerate clmul_64; keep generic helpers for other sizes.
>    * Drop most of the Int128 interfaces, except for clmul_64.
>    * Use the same acceleration format as aes-round.h.
>
>
> r~
>
>
> [1] https://patchew.org/QEMU/20230601123332.3297404-1-ardb@kernel.org/
>
>
> Richard Henderson (19):
>    crypto: Add generic 8-bit carry-less multiply routines
>    target/arm: Use clmul_8* routines
>    target/s390x: Use clmul_8* routines
>    target/ppc: Use clmul_8* routines
>    crypto: Add generic 16-bit carry-less multiply routines
>    target/arm: Use clmul_16* routines
>    target/s390x: Use clmul_16* routines
>    target/ppc: Use clmul_16* routines
>    crypto: Add generic 32-bit carry-less multiply routines
>    target/arm: Use clmul_32* routines
>    target/s390x: Use clmul_32* routines
>    target/ppc: Use clmul_32* routines
>    crypto: Add generic 64-bit carry-less multiply routine
>    target/arm: Use clmul_64
>    target/i386: Use clmul_64
>    target/s390x: Use clmul_64
>    target/ppc: Use clmul_64
>    host/include/i386: Implement clmul.h
>    host/include/aarch64: Implement clmul.h
>
>   host/include/aarch64/host/cpuinfo.h      |   1 +
>   host/include/aarch64/host/crypto/clmul.h |  41 +++++
>   host/include/generic/host/crypto/clmul.h |  15 ++
>   host/include/i386/host/cpuinfo.h         |   1 +
>   host/include/i386/host/crypto/clmul.h    |  29 ++++
>   host/include/x86_64/host/crypto/clmul.h  |   1 +
>   include/crypto/clmul.h                   |  83 ++++++++++
>   include/qemu/cpuid.h                     |   3 +
>   target/arm/tcg/vec_internal.h            |  11 --
>   target/i386/ops_sse.h                    |  40 ++---
>   crypto/clmul.c                           | 112 ++++++++++++++
>   target/arm/tcg/mve_helper.c              |  16 +-
>   target/arm/tcg/vec_helper.c              | 102 ++-----------
>   target/ppc/int_helper.c                  |  64 ++++----
>   target/s390x/tcg/vec_int_helper.c        | 186 ++++++++++-------------
>   util/cpuinfo-aarch64.c                   |   4 +-
>   util/cpuinfo-i386.c                      |   1 +
>   crypto/meson.build                       |   9 +-
>   18 files changed, 434 insertions(+), 285 deletions(-)
>   create mode 100644 host/include/aarch64/host/crypto/clmul.h
>   create mode 100644 host/include/generic/host/crypto/clmul.h
>   create mode 100644 host/include/i386/host/crypto/clmul.h
>   create mode 100644 host/include/x86_64/host/crypto/clmul.h
>   create mode 100644 include/crypto/clmul.h
>   create mode 100644 crypto/clmul.c