[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] sysemu/kvm: Restrict hvf_get_supported_cpuid() to x86 ta
|
From: |
Roman Bolshakov |
|
Subject: |
Re: [PATCH 2/2] sysemu/kvm: Restrict hvf_get_supported_cpuid() to x86 targets |
|
Date: |
Sun, 10 Sep 2023 23:59:42 +0300 |
On Tue, Sep 05, 2023 at 02:39:06PM +0200, Philippe Mathieu-Daudé wrote:
> hvf_get_supported_cpuid() is only defined for x86 targets
> (in target/i386/hvf/x86_cpuid.c).
> Its declaration is pointless on all other targets.
>
> All the calls to it in target/i386/cpu.c are guarded by
> a call on hvf_enabled(), so are elided when HVF is not
> built in. Therefore we can remove the unnecessary function
> stub.
>
Looks good but you also need to include "hvf/hvf-i386.h" to
target/i386/hvf/hvf-cpu.c, otherwise the build fails.
--Roman