[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/i386: Re-introduce few KVM stubs for Clang debug buil
|
From: |
Michael Tokarev |
|
Subject: |
Re: [PATCH] target/i386: Re-introduce few KVM stubs for Clang debug builds |
|
Date: |
Mon, 11 Sep 2023 15:04:45 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 |
11.09.2023 14:56, Stefan Hajnoczi:
Or instead of using linker behavior, maybe just change the #ifdef so it only applies when KVM is disabled. I didn't look at the code to see if this is
possible, but it would be nice to avoid the very specific #ifdef condition in this patch.
Yeah, this is definitely preferrable to define it based on !kvm instead of
!optimize.
I mean the same thing when replied in the pullreq which broke things, - to base
it on !kvm. But use something very similar to what Philippe did with the
functions
themselves (not with the condition).
/mjt