[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/21] parallels: naive implementation of parallels_co_pdisca
From: |
Mike Maslenkin |
Subject: |
Re: [PATCH 18/21] parallels: naive implementation of parallels_co_pdiscard |
Date: |
Sun, 17 Sep 2023 14:40:27 +0300 |
I got a warning after this patch:
../block/parallels.c:541:25: warning: 'guarded_by' attribute only
applies to non-static data members and global variables
[-Wignored-attributes]
static int coroutine_fn GRAPH_RDLOCK_PTR
^
/Users/mg/sources/qemu/include/block/graph-lock.h:85:26: note:
expanded from macro 'GRAPH_RDLOCK_PTR'
#define GRAPH_RDLOCK_PTR TSA_GUARDED_BY(graph_lock)
^
/Users/mg/sources/qemu/include/qemu/clang-tsa.h:48:31: note: expanded
from macro 'TSA_GUARDED_BY'
#define TSA_GUARDED_BY(x) TSA(guarded_by(x))
Regards,
Mike.
On Fri, Sep 15, 2023 at 9:42 PM Denis V. Lunev <den@openvz.org> wrote:
>
> * Discarding with backing stores is not supported by the format.
> * There is no buffering/queueing of the discard operation.
> * Only operations aligned to the cluster are supported.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
> block/parallels.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 76aedfd7c4..83cb8d6722 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -537,6 +537,52 @@ parallels_co_readv(BlockDriverState *bs, int64_t
> sector_num, int nb_sectors,
> return ret;
> }
>
> +
> +static int coroutine_fn GRAPH_RDLOCK_PTR
> +parallels_co_pdiscard(BlockDriverState *bs, int64_t offset, int64_t bytes)
> +{
> + int ret = 0;
> + uint32_t cluster, count;
> + BDRVParallelsState *s = bs->opaque;
> +
> + /*
> + * The image does not support ZERO mark inside the BAT, which means that
> + * stale data could be exposed from the backing file.
> + */
> + if (bs->backing) {
> + return -ENOTSUP;
> + }
> +
> + if (!QEMU_IS_ALIGNED(offset, s->cluster_size)) {
> + return -ENOTSUP;
> + } else if (!QEMU_IS_ALIGNED(bytes, s->cluster_size)) {
> + return -ENOTSUP;
> + }
> +
> + cluster = offset / s->cluster_size;
> + count = bytes / s->cluster_size;
> +
> + qemu_co_mutex_lock(&s->lock);
> + for (; count > 0; cluster++, count--) {
> + int64_t host_off = bat2sect(s, cluster) << BDRV_SECTOR_BITS;
> + if (host_off == 0) {
> + continue;
> + }
> +
> + ret = bdrv_co_pdiscard(bs->file, cluster * s->cluster_size,
> + s->cluster_size);
> + if (ret < 0) {
> + goto done;
> + }
> +
> + parallels_set_bat_entry(s, cluster, 0);
> + bitmap_clear(s->used_bmap, host_cluster_index(s, host_off), 1);
> + }
> +done:
> + qemu_co_mutex_unlock(&s->lock);
> + return ret;
> +}
> +
> static void parallels_check_unclean(BlockDriverState *bs,
> BdrvCheckResult *res,
> BdrvCheckMode fix)
> @@ -1409,6 +1455,7 @@ static BlockDriver bdrv_parallels = {
> .bdrv_co_create = parallels_co_create,
> .bdrv_co_create_opts = parallels_co_create_opts,
> .bdrv_co_check = parallels_co_check,
> + .bdrv_co_pdiscard = parallels_co_pdiscard,
> };
>
> static void bdrv_parallels_init(void)
> --
> 2.34.1
>
- [PATCH 14/21] parallels: accept multiple clusters in mark_used(), (continued)
- [PATCH 14/21] parallels: accept multiple clusters in mark_used(), Denis V. Lunev, 2023/09/15
- [PATCH 19/21] tests: extend test 131 to cover availability of the discard operation, Denis V. Lunev, 2023/09/15
- [PATCH 21/21] tests: extend test 131 to cover availability of the write-zeroes, Denis V. Lunev, 2023/09/15
- [PATCH 20/21] parallels: naive implementation of parallels_co_pwrite_zeroes, Denis V. Lunev, 2023/09/15
- [PATCH 13/21] tests: test self-cure of parallels image with duplicated clusters, Denis V. Lunev, 2023/09/15
- [PATCH 10/21] parallels: add test which will validate data_off fixes through repair, Denis V. Lunev, 2023/09/15
- [PATCH 18/21] parallels: naive implementation of parallels_co_pdiscard, Denis V. Lunev, 2023/09/15
- [PATCH 12/21] tests: fix broken deduplication check in parallels format test, Denis V. Lunev, 2023/09/15
- [PATCH 15/21] parallels: update used bitmap in allocate_cluster, Denis V. Lunev, 2023/09/15
- [PATCH 11/21] parallels: collect bitmap of used clusters at open, Denis V. Lunev, 2023/09/15
- [PATCH 11/21] parallels: collect bitmap of used clusters at open, Denis V. Lunev, 2023/09/15
- [PATCH 17/21] parallels: improve readability of allocate_clusters, Denis V. Lunev, 2023/09/15