[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL V2 16/17] net/dump: Avoid variable length array
From: |
Jason Wang |
Subject: |
[PULL V2 16/17] net/dump: Avoid variable length array |
Date: |
Mon, 18 Sep 2023 16:31:31 +0800 |
From: Peter Maydell <peter.maydell@linaro.org>
Use a g_autofree heap allocation instead of a variable length
array in dump_receive_iov().
The codebase has very few VLAs, and if we can get rid of them all we
can make the compiler error on new additions. This is a defensive
measure against security bugs where an on-stack dynamic allocation
isn't correctly size-checked (e.g. CVE-2021-3527).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dump.c b/net/dump.c
index 7d05f16..16073f2 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -68,7 +68,7 @@ static ssize_t dump_receive_iov(DumpState *s, const struct
iovec *iov, int cnt,
int64_t ts;
int caplen;
size_t size = iov_size(iov, cnt) - offset;
- struct iovec dumpiov[cnt + 1];
+ g_autofree struct iovec *dumpiov = g_new(struct iovec, cnt + 1);
/* Early return in case of previous error. */
if (s->fd < 0) {
--
2.7.4
- [PULL V2 03/17] virtio-net: Add USO flags to vhost support., (continued)
- [PULL V2 03/17] virtio-net: Add USO flags to vhost support., Jason Wang, 2023/09/18
- [PULL V2 05/17] igb: remove TCP ACK detection, Jason Wang, 2023/09/18
- [PULL V2 04/17] virtio-net: Add support for USO features, Jason Wang, 2023/09/18
- [PULL V2 09/17] igb: add IPv6 extended headers traffic detection, Jason Wang, 2023/09/18
- [PULL V2 06/17] igb: rename E1000E_RingInfo_st, Jason Wang, 2023/09/18
- [PULL V2 07/17] igb: RX descriptors guest writting refactoring, Jason Wang, 2023/09/18
- [PULL V2 08/17] igb: RX payload guest writting refactoring, Jason Wang, 2023/09/18
- [PULL V2 10/17] igb: packet-split descriptors support, Jason Wang, 2023/09/18
- [PULL V2 11/17] e1000e: rename e1000e_ba_state and e1000e_write_hdr_to_rx_buffers, Jason Wang, 2023/09/18
- [PULL V2 14/17] hw/net/fsl_etsec/rings.c: Avoid variable length array, Jason Wang, 2023/09/18
- [PULL V2 16/17] net/dump: Avoid variable length array,
Jason Wang <=
- [PULL V2 15/17] hw/net/rocker: Avoid variable length array, Jason Wang, 2023/09/18
- [PULL V2 12/17] tests: bump libvirt-ci for libasan and libxdp, Jason Wang, 2023/09/18
- [PULL V2 13/17] net: add initial support for AF_XDP network backend, Jason Wang, 2023/09/18
- [PULL V2 17/17] net/tap: Avoid variable-length array, Jason Wang, 2023/09/18
- Re: [PULL V2 00/17] Net patches, Stefan Hajnoczi, 2023/09/19