[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [QEMU PATCH v5 05/13] virtio-gpu: Configure context init for virglre
From: |
Huang Rui |
Subject: |
Re: [QEMU PATCH v5 05/13] virtio-gpu: Configure context init for virglrenderer |
Date: |
Wed, 20 Sep 2023 16:04:39 +0800 |
On Tue, Sep 19, 2023 at 04:17:43PM +0800, Marc-André Lureau wrote:
> Hi
>
> On Fri, Sep 15, 2023 at 6:16 PM Huang Rui <ray.huang@amd.com> wrote:
> >
> > Configure context init feature flag for virglrenderer.
> >
> > Originally-by: Antonio Caggiano <antonio.caggiano@collabora.com>
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> >
> > V4 -> V5:
> > - Inverted patch 5 and 6 because we should configure
> > HAVE_VIRGL_CONTEXT_INIT firstly. (Philippe)
> >
> > meson.build | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/meson.build b/meson.build
> > index 98e68ef0b1..ff20d3c249 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1068,6 +1068,10 @@ if not get_option('virglrenderer').auto() or
> > have_system or have_vhost_user_gpu
> > prefix: '#include
> > <virglrenderer.h>',
> > dependencies: virgl))
> > endif
> > + config_host_data.set('HAVE_VIRGL_CONTEXT_INIT',
> > +
> > cc.has_function('virgl_renderer_context_create_with_flags',
> > + prefix: '#include
> > <virglrenderer.h>',
> > + dependencies: virgl))
>
> Move it under the "if virgl.found()" block above.
>
> I suggest to name it after what is actually checked:
> HAVE_VIRGL_CONTEXT_CREATE_WITH_FLAGS for ex
>
OK, will update it in V6.
Thanks,
Ray
> > endif
> > blkio = not_found
> > if not get_option('blkio').auto() or have_block
> > --
> > 2.34.1
> >
> >
>
>
> --
> Marc-André Lureau
- [QEMU PATCH v5 00/13] Support blob memory and venus on qemu, Huang Rui, 2023/09/15
- [QEMU PATCH v5 01/13] virtio: Add shared memory capability, Huang Rui, 2023/09/15
- [QEMU PATCH v5 02/13] virtio-gpu: CONTEXT_INIT feature, Huang Rui, 2023/09/15
- [QEMU PATCH v5 03/13] virtio-gpu: hostmem, Huang Rui, 2023/09/15
- [QEMU PATCH v5 04/13] virtio-gpu: blob prep, Huang Rui, 2023/09/15
- [QEMU PATCH v5 05/13] virtio-gpu: Configure context init for virglrenderer, Huang Rui, 2023/09/15
- [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Huang Rui, 2023/09/15
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Akihiko Odaki, 2023/09/15
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Huang Rui, 2023/09/16
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Akihiko Odaki, 2023/09/16
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Huang Rui, 2023/09/17
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Akihiko Odaki, 2023/09/17
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Huang Rui, 2023/09/18
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Akihiko Odaki, 2023/09/18
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Huang Rui, 2023/09/18
- Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer, Akihiko Odaki, 2023/09/18