[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/52] migration/rdma: Drop qemu_rdma_search_ram_block() erro
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 12/52] migration/rdma: Drop qemu_rdma_search_ram_block() error handling |
Date: |
Wed, 20 Sep 2023 15:11:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Fabiano Rosas <farosas@suse.de> writes:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> qemu_rdma_search_ram_block() can't fail. Return void, and drop the
>> unreachable error handling.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> migration/rdma.c | 22 ++++++++--------------
>> 1 file changed, 8 insertions(+), 14 deletions(-)
>>
>> diff --git a/migration/rdma.c b/migration/rdma.c
>> index 2b0f9d52d8..98520a42b4 100644
>> --- a/migration/rdma.c
>> +++ b/migration/rdma.c
>> @@ -1234,12 +1234,12 @@ static int
>> qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma)
>> *
>> * This search cannot fail or the migration will fail.
>> */
>
> This comment can be removed as well.
Will do, thanks!
[...]
- [PATCH 00/52] migration/rdma: Error handling fixes, Markus Armbruster, 2023/09/18
- [PATCH 01/52] migration/rdma: Clean up qemu_rdma_poll()'s return type, Markus Armbruster, 2023/09/18
- [PATCH 12/52] migration/rdma: Drop qemu_rdma_search_ram_block() error handling, Markus Armbruster, 2023/09/18
- [PATCH 02/52] migration/rdma: Clean up qemu_rdma_data_init()'s return type, Markus Armbruster, 2023/09/18
- [PATCH 27/52] migration/rdma: Drop superfluous assignments to @ret, Markus Armbruster, 2023/09/18
- [PATCH 20/52] migration/rdma: Drop dead qemu_rdma_data_init() code for !@host_port, Markus Armbruster, 2023/09/18
- [PATCH 46/52] migration/rdma: Silence qemu_rdma_reg_control(), Markus Armbruster, 2023/09/18