|
From: | Markus Armbruster |
Subject: | Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored |
Date: | Mon, 25 Sep 2023 09:09:44 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
"Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com> writes: > On 18/09/2023 22:41, Markus Armbruster wrote: >> All we do with the value of RDMAContext member @error_state is test >> whether it's zero. Change to bool and rename to @errored. >> > > make sense! > > Reviewed-by: Li Zhijian <lizhijian@fujitsu.com> > > Can we move this patch ahead "[PATCH 23/52] migration/rdma: Clean up > qemu_rdma_wait_comp_channel()'s error value", > so that [23/52] [24/52] [25/52] will be more easy to review. I think I could squash PATCH 23 into "[PATCH 25/52] migration/rdma: Dumb down remaining int error values to -1". Would that work for you?
[Prev in Thread] | Current Thread | [Next in Thread] |