qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/20] q800-glue.c: convert to Resettable interface


From: Laurent Vivier
Subject: Re: [PATCH v2 01/20] q800-glue.c: convert to Resettable interface
Date: Mon, 25 Sep 2023 19:03:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
Convert the GLUE device to 3-phase reset. The legacy method
doesn't do anything that's invalid in the hold phase, so the
conversion is simple and not a behaviour change.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  hw/m68k/q800-glue.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/m68k/q800-glue.c b/hw/m68k/q800-glue.c
index 34c4f0e987..710a5c331e 100644
--- a/hw/m68k/q800-glue.c
+++ b/hw/m68k/q800-glue.c
@@ -166,9 +166,9 @@ static void glue_nmi_release(void *opaque)
      GLUE_set_irq(s, GLUE_IRQ_IN_NMI, 0);
  }
-static void glue_reset(DeviceState *dev)
+static void glue_reset_hold(Object *obj)
  {
-    GLUEState *s = GLUE(dev);
+    GLUEState *s = GLUE(obj);
s->ipr = 0;
      s->auxmode = 0;
@@ -223,11 +223,12 @@ static void glue_init(Object *obj)
  static void glue_class_init(ObjectClass *klass, void *data)
  {
      DeviceClass *dc = DEVICE_CLASS(klass);
+    ResettableClass *rc = RESETTABLE_CLASS(klass);
      NMIClass *nc = NMI_CLASS(klass);
dc->vmsd = &vmstate_glue;
-    dc->reset = glue_reset;
      device_class_set_props(dc, glue_properties);
+    rc->phases.hold = glue_reset_hold;
      nc->nmi_monitor_handler = glue_nmi;
  }

Reviewed-by: Laurent Vivier <laurent@vivier.eu>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]