[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/i386/seg_helper: remove shadowed variable
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH] target/i386/seg_helper: remove shadowed variable |
|
Date: |
Tue, 26 Sep 2023 16:53:45 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il mar 26 set 2023, 15:16 Markus Armbruster <armbru@redhat.com> ha scritto:
>
>> I still get these:
>>
>> ../target/i386/tcg/seg_helper.c: In function ‘switch_tss_ra’:
>> ../target/i386/tcg/seg_helper.c:344:22: warning: declaration of ‘ptr’
>> shadows a previous local [-Wshadow=compatible-local]
>> 344 | target_ulong ptr;
>> | ^~~
>> ../target/i386/tcg/seg_helper.c:245:18: note: shadowed declaration is here
>> 245 | target_ulong ptr;
>> | ^~~
>> ../target/i386/tcg/seg_helper.c:345:18: warning: declaration of ‘e2’
>> shadows a parameter [-Wshadow=compatible-local]
>> 345 | uint32_t e2;
>> | ^~
>> ../target/i386/tcg/seg_helper.c:235:48: note: shadowed declaration is here
>> 235 | uint32_t e1, uint32_t e2, int source,
>> | ~~~~~~~~~^~
>> ../target/i386/tcg/seg_helper.c:402:22: warning: declaration of ‘ptr’
>> shadows a previous local [-Wshadow=compatible-local]
>> 402 | target_ulong ptr;
>> | ^~~
>> ../target/i386/tcg/seg_helper.c:245:18: note: shadowed declaration is here
>> 245 | target_ulong ptr;
>> | ^~~
>> ../target/i386/tcg/seg_helper.c:403:18: warning: declaration of ‘e2’
>> shadows a parameter [-Wshadow=compatible-local]
>> 403 | uint32_t e2;
>> | ^~
>> ../target/i386/tcg/seg_helper.c:235:48: note: shadowed declaration is here
>> 235 | uint32_t e1, uint32_t e2, int source,
>> | ~~~~~~~~~^~
>>
>
> There's another seg_helper patch. 8)
Ah, missed it, because it doesn't have "shadow" in the subject. Added
to my collection now. Thanks!