[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 0/9] qapi-go: add generator for Golang interface
From: |
Victor Toso |
Subject: |
Re: [PATCH v1 0/9] qapi-go: add generator for Golang interface |
Date: |
Fri, 29 Sep 2023 16:08:36 +0200 |
Hi,
On Thu, Sep 28, 2023 at 02:54:10PM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 28, 2023 at 02:40:27PM +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 27, 2023 at 01:25:35PM +0200, Victor Toso wrote:
> > IOW, it would push towards
> >
> > go-qemu.git
> > go-qga.git
> > go-qsd.git
> >
> > and at time of each QEMU release, we would need to invoke the code
> > generator, and store its output in the respective git modules.
> >
> > This would also need the generator application to be a standalone
> > tool, separate from the C QAPI generator.
>
> Oh, and we need to assume that all CONFIG conditionals in the QAPI
> files are true, as we want the Go API to be feature complete such
> that it can be used with any QEMU build, regardless of which CONFIG
> conditions are turned on/off. We also don't want applications to
> suddenly fail to compile because some API was stopped being generated
> by a disabled CONFIG condition - it needs to be a runtime error
> that apps can catch and handle as they desire.
I haven't tested if what is provided to scripts/qapi/golang.py
relies on enabled CONFIG only, I think not. But yes, the
generated module should have it all.
Cheers,
Victor
signature.asc
Description: PGP signature
- Re: [PATCH v1 7/9] qapi: golang: Generate qapi's command types in Go, (continued)