Re: [PATCH] Revert "hw/virtio: Add support for VDPA network simulation devices"

[Michael S. Tsirkin]

On Mon, Apr 08, 2024 at 10:11:18PM +0200, Paolo Bonzini wrote:
> 
> 
> Il lun 8 apr 2024, 12:18 Michael S. Tsirkin <mst@redhat.com> ha scritto:
> 
>     On Mon, Apr 08, 2024 at 10:51:57AM +0100, Peter Maydell wrote:
>     > On Mon, 8 Apr 2024 at 10:48, Michael S. Tsirkin <mst@redhat.com> wrote:
>     > >
>     > > This reverts commit cd341fd1ffded978b2aa0b5309b00be7c42e347c.
>     > >
>     > > The patch adds non-upstream code in
>     > > include/standard-headers/linux/virtio_pci.h
>     > > which would make maintainance harder.
>     > >
>     > > Revert for now.
> 
> 
> As long as it is part of the spec, why not just move the problematic parts to 
> a
> QEMU specific header? As far as I understand the kernel is never going to
> consume these constants anyway. 
> 
> Paolo 

I expect the contributor to do fixups like this though, not myself.

> 
>     > > Suggested-by: Jason Wang <jasowang@redhat.com>
>     > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>     >
>     > Are you intending to target this revert for 9.0 ?
>     >
>     > -- PMM
> 
>     Yes.
> 
>