Re: [ShopSuite-dev] [rational type] X/1 --> X

[Davi Leal]

Tomasz Wegrzanowski wrote:

> You have misconfigured mail agent. It sent rational.c as image/x-bitmap.
> As sgn is bool, true/false, not 1/0 should be used.
> Otherwise, new rational.c seems ok, and it passed test.sql

I have used 'nestacape mail' and 'kmail' and I do not see your 'rational.c' 
attachment. Could
you send it again? (directly to me if you want).



> Oh, and I'm not sure if compile version is multithread-ok, or some mutex 
> should
> be used :(

Uhmm, What shared resources keeps the rational.c plug-in?.  (I am now at irc)



> > > > P.D.: Could you design and develop the modification of 
> > > > 'rational/Makefile' so as to
> > > > add the 'make test' line?. I think you will realize it easier than me. 
> > > > -- If you
> > > > agree, please send it so that I can commit it.
> > >
> > > There are some problems with `make test':
> > > * how to reload pg from makefile, we could just assume we're running 
> > > debian
> > >   and ask for root passwd ?
> >
> > > * what database is used for testing ?
> >
> > Uhmm. Too much complex. Forbide it. I will add a 'test' to the doc/TODO 
> > file to check the
> > rational pluggin by hand. What do you think?
> >
> > -- doc/TODO
> > * rational plug-in test
> >   # This test assume that the PostgreSQL and rational plug-in
> >   # installation is correct and that there is a shop data base. See the
> >   # /README file to realize it.
> >   psql shop < test.sql
> >   # Inspect the output by hand
>
> You didn't read the output, did you ?

Yes, I did it.  :)



> * rational plug-in test
>   # This test assume that the PostgreSQL and rational plug-in
>   # installation is correct and that there is a shop data base. See the
>   # /README file to realize it.
>   psql shop < test.sql > real.out
>   diff -u expected.out real.out
>   # Inspect the output by hand

OK, I will do it as this way.