Re: IceCat bugs

[rmyster]

> I am experiencing similar issues. In my case, some toolbars (i.e. the
> toolbar created by the web developer addon, a custom toolbar i have
> created) disappear when the privacy extension is enabled.
>
> I am I am quite sure the problem is related with the privacy extension
> because I did some test starting IceCat in safe mode and also with a
> fresh profile, and the problem happened only enabling the privacy
> extension.
>

The webdeveloper/privacy extension conflict started with the icecat
3.6.9 privacy_ext.xpi release.  The 3.6.8 and earlier versions did not
cause a disappearing webdeveloper toolbar.

Three files show changes between the 3.68 & 3.6.9 privacy_ext.xpi  versions:

./chrome.manifest
./chrome/locale/en-US/privacy_features.properties
./content/overlay.js

Differences are shown below.  The only real change to overlay.js is
the checkIfJS function at the end.  The other differences are
licensing at the top and line wrapping differences.  My best guess is
the web developer disappearing toolbar issue is related to the
checkIfJS function addition.

In any event,  3.6.9-3.6.13 privacy_ext.xpi files all cause the same
disappearing toolbars on the webdeveloper extension but the older
3.6.8 pivacy_ext.xpi still works on newer icecat releases.


Changelog 3.6.8 to 3.6.9:
        * content/overlay.js: Alert the user if javascript code is entered in
        the address bar.
        * chrome/locale/es-AR/privacy_features.properties: Add `javascript_url'.
        * chrome/locale/en-US/privacy_features.properties: Likewise.
        * chrome/locale/it-IT/privacy_features.properties: Likewise.
        * chrome.manifest: Fix locale name.


diff 3.6.8 3.6.9  ./chrome.manifest
---------------------------------------------------------------------
6c6
< locale privacy_features en-US chrome/locale/es-AR/
---
> locale privacy_features es-AR chrome/locale/es-AR/





diff 3.6.8 3.6.9  ./chrome/locale/en-US/privacy_features.properties
---------------------------------------------------------------------
3c3,4
< block_site_cookies=Block cookies from
\ No newline at end of file
---
> block_site_cookies=Block cookies from
> javascript_url=Execute javascript code in the address bar can cause privacy 
> problems.






diff 3.6.8 3.6.9  ./content/overlay.js
---------------------------------------------------------------------
1c1,19
< var cookiesHost = new Object();
---
> /*
>   GNUzilla privacy features
>   Copyright (C) 2008, 2009, 2010 Free Software
>   Foundation, Inc.
>   This program is free software; you can redistribute it and/or modify
>   it under the terms of the GNU General Public License as published by
>   the Free Software Foundation; either version 3 of the License, or
>   (at your option) any later version.
>
>   This program is distributed in the hope that it will be useful,
>   but WITHOUT ANY WARRANTY; without even the implied warranty of
>   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   GNU General Public License for more details.
>
>   You should have received a copy of the GNU General Public License
>   along with this program.  If not, see <http://www.gnu.org/licenses/>.
> */
>
> var cookiesHost = new Object ();
5c23
<   observe: function(subject, topic, data)
---
>   observe: function (subject, topic, data)
20c38,39
<         var interfaceRequestor =
httpChannel.notificationCallbacks.QueryInterface(Components.interfaces.nsIInterfaceRequestor);
---
>         var interfaceRequestor = httpChannel.notificationCallbacks
>         .QueryInterface(Components.interfaces.nsIInterfaceRequestor);
26c45,46
<         if(cookie != null && targetBrowserIndex > -1 &&
targetDoc.location.host != httpChannel.URI.host)
---
>         if(cookie != null && targetBrowserIndex > -1
>            && targetDoc.location.host != httpChannel.URI.host)
38c58,59
<               var perm =
Components.classes["@mozilla.org/cookie/permission;1"].getService(Components.interfaces.nsICookiePermission);
---
>               var perm = 
> Components.classes["@mozilla.org/cookie/permission;1"]
>               .getService(Components.interfaces.nsICookiePermission);
62c83
<
---
>
67a89
>
69c91,92
<     var observerService =
Components.classes["@mozilla.org/observer-service;1"].getService(Components.interfaces.nsIObserverService);
---
>     var observerService = 
> Components.classes["@mozilla.org/observer-service;1"]
>     .getService(Components.interfaces.nsIObserverService);
71c94,95
<     observerService.addObserver(privacyFeaturesCookiesObserver,
"http-on-modify-request", false);
---
>     observerService.addObserver(privacyFeaturesCookiesObserver,
>                                 "http-on-modify-request", false);
75,76c99,100
< window.addEventListener("load", function(e) {
PrivacyFeatures.onLoad(e); }, false);
< window.addEventListener("DOMAttrModified", function(ev) {
---
> window.addEventListener("load", function(e) { PrivacyFeatures.onLoad(e); }, 
> false);
> window.addEventListener("DOMAttrModified", function(ev) {
87a112,141
>
>
>
> function checkIfJS (e)
> {
>   if (document.getElementById ("urlbar").value.indexOf ("javascript:") != 0)
>     return;
>
>   var prefs = Components.classes["@mozilla.org/preferences-service;1"]
>     .getService (Components.interfaces.nsIPrefService)
>     .getBranch ("extensions.gnuzilla_privacy_features.");
>
>   var allow = prefs.prefHasUserValue("allowJsAddressBar")
>     && prefs.getBoolPref("allowJsAddressBar");
>
>   if (! allow)
>     {
>       var stringsBundle = document.getElementById("string-bundle");
>       var messageString = stringsBundle.getString('javascript_url');
>       var notificationBox = gBrowser.getNotificationBox();
>       notificationBox.appendNotification(messageString,
>                                          null,
>                                          null,
>                                          
> notificationBox.PRIORITY_WARNING_MEDIUM,
>                                          null);
>     }
>
> }
>
> document.getElementById ("urlbar").addEventListener ("input", checkIfJS, 
> false);