[bug-mailutils] Buglet in libmu_scm/Makefile.am?

[Jordi Mallach]

Hello,

The m68k buildd recently choked on the $here variable on this Makefile.

install-data-hook:
        @here=`pwd`
         cd $(DESTDIR)$(libdir);\
         if test -f libmu_scm.so; then \
                $(LN_S) -f libmu_scm.so libguile-mailutils-v-$(VERSION).so; \
         fi; \
         cd $$here

When I looked at it, I first wondered if it was needed at all, but I let
it be, thinking it was a buildd setup error.

Well, the m68k people filed a bug, and they think it's really a bug in
the Makefile. Stephen Marenka proposed this fix:


 install-data-hook:
-       @here=`pwd`
+       @here=`pwd`;\
         cd $(DESTDIR)$(libdir);\
         if test -f libmu_scm.so; then \
                $(LN_S) -f libmu_scm.so libguile-mailutils-v-$(VERSION).so; \

But they also think the whole variable thing is completely unecessary,
as the stuff is executed in a subshell, and you'll go back to the
previous pwd when the clause finishes.

Is there a good reason for doing this?

Jordi
-- 
Jordi Mallach Pérez  --  Debian developer     http://www.debian.org/
address@hidden     address@hidden     http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/~jordi/

pgpnZEaZvd5Ky.pgp
Description: PGP signature