Re: [Emacs-diffs] scratch/so-long d216f81: fixup! Add so-long library

[Stefan Monnier]

> +(defun turn-on-so-long-minor-mode ()
> +  "Enable minor mode `so-long-minor-mode'."
> +  (so-long-minor-mode 1))

You don't need to pass `1`, so you could also write:

    (defalias 'turn-on-so-long-minor-mode #'so-long-minor-mode)
    
or just don't define turn-on-so-long-minor-mode at all, which is what
I recommend.

> +(defun turn-off-so-long-minor-mode ()
> +  "Disable minor mode `so-long-minor-mode'."
> +  (so-long-minor-mode -1))

I also recommend not to bother defining the turn-off function and let
users call (so-long-minor-mode -1) for the few cases where they might
need it.


        Stefan