emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/so-long d216f81: fixup! Add so-long library


From: Phil Sainty
Subject: Re: [Emacs-diffs] scratch/so-long d216f81: fixup! Add so-long library
Date: Mon, 15 Apr 2019 10:24:55 +1200
User-agent: Orcon Webmail

On 2019-04-15 03:03, Stefan Monnier wrote:
or just don't define turn-on-so-long-minor-mode at all, which is what
I recommend.

I also recommend not to bother defining the turn-off function and let
users call (so-long-minor-mode -1) for the few cases where they might
need it.

The actual reason for defining these functions is for the associated
so-long-action-alist entry:

    (so-long-minor-mode
     "Enable so-long-minor-mode"
     turn-on-so-long-minor-mode
     turn-off-so-long-minor-mode)

This kept things nice and simple.

We could get away without the turn-on function, but I felt the resulting
lack of symmetry would be strange, so opted to have them both.


-Phil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]