[emms-help] error in emms-lyrics-start

[Andrea Russo]

Hi,

After upgrading to a recent revision of emacs cvs [1] I experienced an
annoying behavior of emms-lyrics-read-file in emms-lyrics.el when
playing some streams.  It seems that using file-exists-p on an url
triggers some tramp function which result in throwing an error.

I don't know if this happens only to me or if it's a bad configured
emacs but the attached patch is my attempt to solve the problem.

I included also the backtrace of the error.

Thanks,
Andrea.

diff -rN -u old-emms2/emms-lyrics.el new-emms2/emms-lyrics.el
--- old-emms2/emms-lyrics.el    2006-06-14 02:41:39.000000000 +0200
+++ new-emms2/emms-lyrics.el    2006-06-14 02:41:39.000000000 +0200
@@ -129,7 +129,7 @@
 (defvar emms-lyrics-mode-line-string ""
   "current lyric.")
 
-(defun emms-lyrics-read-file (file)
+(defun emms-lyrics-read-file (file type)
   "Read a lyric file(LRC format). File should end up with \".lrc\", its
 contents look like one of the following:
 
@@ -138,7 +138,8 @@
     [00:39.67]I love you, Emacs!
 
 To find FILE, will look up in current directory and `emms-lyrics-dir'."
-  (unless (file-exists-p file)
+  (unless (and (eq type 'file)
+              (file-exists-p file))
     (setq file (emms-lyrics-find-lyric file)))
   (when (and file (not (string= file "")) (file-exists-p file))
     (with-temp-buffer
@@ -179,7 +180,10 @@
                'name)))
          (emms-lyrics-read-file
           (emms-replace-regexp-in-string
-           (file-name-extension file) "lrc" file)))
+           (file-name-extension file) "lrc" file)
+          (emms-track-get
+           (emms-playlist-current-selected-track)
+           'type)))
     (emms-lyrics-set-timer)))
 
 (defun emms-lyrics-stop ()


Debugger entered--Lisp error: (error "Login failed")
  signal(error ("Login failed"))
  error("Login failed")
  tramp-process-actions(#<process *tramp/ssh http*> nil "ssh" nil "http" 
((tramp-password-prompt-regexp tramp-action-password) 
(tramp-login-prompt-regexp tramp-action-login) (shell-prompt-pattern 
tramp-action-succeed) (tramp-shell-prompt-pattern tramp-action-succeed) 
(tramp-wrong-passwd-regexp tramp-action-permission-denied) 
(tramp-yesno-prompt-regexp tramp-action-yesno) (tramp-yn-prompt-regexp 
tramp-action-yn) (tramp-terminal-prompt-regexp tramp-action-terminal) 
(tramp-process-alive-regexp tramp-action-process-alive)))
  tramp-open-connection-rsh(nil "ssh" nil "http")
  tramp-maybe-open-connection(nil "ssh" nil "http")
  tramp-get-file-exists-command(nil "ssh" nil "http")
  
tramp-handle-file-exists-p("/ssh:http:/movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.lrc")
  apply(tramp-handle-file-exists-p 
"/ssh:http:/movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.lrc")
  tramp-sh-file-name-handler(file-exists-p 
"/ssh:http:/movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.lrc")
  apply(tramp-sh-file-name-handler file-exists-p 
"/ssh:http:/movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.lrc")
  tramp-file-name-handler(file-exists-p 
"/ssh:http:/movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.lrc")
  
file-exists-p("http://movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.lrc";)
  
emms-lyrics-read-file("http://movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.lrc";)
  emms-lyrics-start()
  run-hooks(emms-player-started-hook)
  emms-player-started((*player* (start . emms-player-mplayer-start) (stop . 
emms-player-mplayer-stop) (playablep . emms-player-mplayer-playable-p) (regex . 
"\\.\\(?:a\\(?:sf\\|vi\\)\\|divx\\|flac\\|m\\(?:4v\\|kv\\|ov\\|p\\(?:eg\\|[34g]\\)\\)\\|og[gm]\\|rm\\(?:vb\\)?\\|w\\(?:av\\|m[av]\\)\\)\\|http://";)
 (pause . emms-player-simple-pause) (resume . emms-player-simple-resume) (seek 
. emms-player-mplayer-seek)))
  
emms-player-simple-start("http://movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.mp4";
 (*player* (start . emms-player-mplayer-start) (stop . 
emms-player-mplayer-stop) (playablep . emms-player-mplayer-playable-p) (regex . 
"\\.\\(?:a\\(?:sf\\|vi\\)\\|divx\\|flac\\|m\\(?:4v\\|kv\\|ov\\|p\\(?:eg\\|[34g]\\)\\)\\|og[gm]\\|rm\\(?:vb\\)?\\|w\\(?:av\\|m[av]\\)\\)\\|http://";)
 (pause . emms-player-simple-pause) (resume . emms-player-simple-resume) (seek 
. emms-player-mplayer-seek)) "mplayer" ("-slave" "-quiet"))
  emms-player-mplayer-start((*track* (type . url) (name . 
"http://movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.mp4";) 
(info-mtime) (metadata)))
  emms-player-start((*track* (type . url) (name . 
"http://movies4.arcoiris.tv/movies/luogo_comune/loose_change_2.mp4";) 
(info-mtime) (metadata)))
  emms-start()
  emms-playlist-mode-play-current-track()
  emms-playlist-mode-play-dtrt()
  call-interactively(emms-playlist-mode-play-dtrt)


Footnotes: 
[1]  (GNU Emacs 22.0.50.12 (i686-pc-linux-gnu, GTK+ Version 2.8.17) of 
2006-06-11 on onosendai.org)

-- 
Raro cade chi ben cammina.
                -- Leonardo da Vinci