[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage
From: |
Ludovic Courtès |
Subject: |
[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage |
Date: |
Sat, 23 Jun 2018 23:54:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Julien Lepiller <address@hidden> skribis:
> Le Fri, 22 Jun 2018 21:54:45 +0200,
> address@hidden (Ludovic Courtès) a écrit :
>
>> Could you clarify which issue this fixes?
>>
>> Also, I think you really want ‘native-search-paths’ and not
>> ‘search-paths’. The latter is meant to be used by things like
>> cross-compilers.
>>
>> Thanks,
>> Ludo’.
>
> The issue was that a part of the code was only partially patched. It
> looked like:
>
> plugdir = ALSA_PLUGIN_DIR;
> envplugdir = getenv("ALSA_PLUGIN_DIR");
> if(envplugdir != NULL)
> plugdir = envplugdir;
> ...
> sofile = malloc(sizeof(plugdir) + ...);
> ...
> sprintf(sofile, "%s/whatever.so", ALSA_PLUGIN_DIR);
>
> If at compilation time ALSA_PLUGIN_DIR is bigger than the runtime
> $ALSA_PLUGIN_DIR, we are in trouble: alsa-lib will crash because of a
> buffer overflow. Otherwise, it just didn't care about $ALSA_PLUGIN_DIR.
Alright, so the patch update can definitely go in!
> The native-search-paths vs search-paths is a bit confusing... I need to
> read the manual more carefully I guess.
The manual doesn’t say much about this, so you have a good excuse.
But anyway, that change is surely not necessary.
Thanks,
Ludo’.
- [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage, Julien Lepiller, 2018/06/22
- [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage, Ludovic Courtès, 2018/06/22
- [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage, 宋文武, 2018/06/24
- [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins., Oleg Pykhalov, 2018/06/24
- [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins., 宋文武, 2018/06/25
- [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins., Julien Lepiller, 2018/06/25
- [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins., 宋文武, 2018/06/26
- [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins., Marius Bakke, 2018/06/26
- bug#31934: [PATCH] services: sound: Properly handle alsa-plugins., 宋文武, 2018/06/26
- [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins., Marius Bakke, 2018/06/26
- [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins., Ludovic Courtès, 2018/06/26