guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#66426] [PATCH 00/65] Export %default-gnu-imported-modules and %defa


From: Liliana Marie Prikler
Subject: [bug#66426] [PATCH 00/65] Export %default-gnu-imported-modules and %default-gnu-modules.
Date: Tue, 10 Oct 2023 06:14:36 +0200
User-agent: Evolution 3.46.4

Am Montag, dem 09.10.2023 um 21:31 -0400 schrieb Maxim Cournoyer:
> Hi Liliana,
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> > Hmm, at the very least I'd like to bikeshed the variable names,
> > hence my suggestion to encode it into the build system itself,
> > which would allow any name locally.  %default-anything reads weird
> > to me, plus it's a mouthful for imported modules.
> 
> It seems conventional to me: we have %default-subtitute-urls,
> %default-channels, %default-include (thousands of matches for
> '%default-' upon grepping).
Fair enough, but in the cases you've named it's still %default for more
than one build system.  Or do you by extension want %default-glib-or-
gtk-imported-modules?  That's quite a mouthful imho without any
additional semantics.

> > WDYT about %gnu-build-modules and %gnu-build-system-modules, where
> > %gnu-build-system-modules keeps its current intent for being
> > imported?
> > Alternatively we could also rename it to %gnu-build-imported-
> > modules
> > with a deprecated alias.
> 
> People have been adding %gnu-build-system-modules to #:modules
> erroneously.  Not renaming that would ensure this keeps happening.
> Having 'imported-modules' in the name seems like it'd make things a
> bit easier to remember; thus, I think the proposed naming is
> adequate?
Perhaps, but I think %gnu-build-modules and %gnu-build-imported-modules
is better even with that reasoning.

Cheers





reply via email to

[Prev in Thread] Current Thread [Next in Thread]