bug#66426: [PATCH 00/65] Export %default-gnu-imported-modules and %default-gnu-modules.

[Maxim Cournoyer]

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello,
>
> [...]
>
>>>> People have been adding %gnu-build-system-modules to #:modules
>>>> erroneously.  Not renaming that would ensure this keeps happening.
>>>> Having 'imported-modules' in the name seems like it'd make things a
>>>> bit easier to remember; thus, I think the proposed naming is
>>>> adequate?
>>> Perhaps, but I think %gnu-build-modules and %gnu-build-imported-modules
>>> is better even with that reasoning.
>>
>> So we'd use for example %glib-or-gtk-build-imported-modules?  The
>> difference is small to what I proposed (swap the leading default for an
>> in-middle 'build' -- 2 characters), so I don't think your 'mouthful'
>> argument holds, but I don't have much of an issue with it, except
>> perhaps that 'build' is not directly attached to the module namespace,
>> which is (guix build-systems gnu) for example.
>>
>> I still prefer my naming, but yeah, we're choosing the color of the bike
>> shed :-).  If others could tip in, that may help decide, otherwise I'd
>> prefer leaving it as-is.  Does that sound reasonable?
>
> I just realized that the whole series had been sent mistakenly to
> another series (seems I messed up using 'mumi send'):
> <https://issues.guix.gnu.org/65924#18>.
>
> I did spot a couple errors in that series that I've resolved locally.
>
> If nobody has further concerns, I'll merge it later today to the
> core-updates branch.

I've now done so.  Thanks for the review/comments!

-- 
Thanks,
Maxim