[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] Bytecode handling and printing refactoring
|
From: |
Holger Hans Peter Freyther |
|
Subject: |
Re: [Help-smalltalk] [PATCH] Bytecode handling and printing refactoring |
|
Date: |
Fri, 13 Dec 2013 16:08:38 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Dec 13, 2013 at 02:46:19PM +0100, Gwenaël Casaccio wrote:
> Hi,
Hi!
> I've removed the bytecode decoding, dispatching and printing methods from
> CompiledCode class. Instead they are moved to they related
> BytecodeDispatcher and ByteodePrinter classes. It makes the bytecode
> handling code nicer, smaller, reusable and extendable.
good idea. But you seem to create copies of specialSelectorsNumArgs,
bytecodeInfoTable and specialSelectors. Why can't you remove that from
the CompildCode class?