[Lilypond-auto] Issue 3593 in lilypond: Completion_heads_engraver generates spurious accidentals

[lilypond]

Status: Started
Owner: address@hidden
CC: address@hidden
Labels: Type-Critical

New issue 3593 by address@hidden: Completion_heads_engraver generates spurious  
accidentals
http://code.google.com/p/lilypond/issues/detail?id=3593

Wish I did not have to enter this myself.

Cf thread starting with  
<URL:http://lists.gnu.org/archive/html/lilypond-user/2013-10/msg00036.html>.

This shows several issues with the completion heads engraver's treatment of  
accidentals.  This issue is about the regression, namely accidentals  
occuring in tied-after notes.

The regression started with
2.17.2.

6c98920d868524eee3e809578ad4389d409a566a is the first bad commit
commit 6c98920d868524eee3e809578ad4389d409a566a
Author: Mike Solomon <address@hidden>
Date:   Mon Sep 10 08:53:09 2012 +0200

    Avoids script-tie collisions

    Ties are now issued at their correct beginning time step and
    are suicided if they are ultimately unused.  This allows the
    Script_engraver to acknowledge them at the correct timestep and
    register them as supports for the side-position-interface.

The changes in that commit were not reflected in the completion engravers.   
The fix chosen here is _not_ a full reflection of the changed design: while  
the ties' ends are now being announced (this omission caused the original  
problem), the beginnings of the ties are announced at the same point of  
time.  That means that overrides and similar are taken from the time at the  
_end_ of the tie, and it is conceivable that the collision avoidance  
mechanisms are not fully operative (though reasonably they can't be  
expected to start work before the end of the tie is known).

A more comprehensive rewrite would be warranted.

What this issue is _not_ about are the non-regression issues mentioned in  
the thread: repetition of _forced_ accidentals and of articulations.

Attachments:
        xxx.ly  909 bytes

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings