Re: New feature: automatically invert chords or drop/rise chord notes (issue 365840043 by address@hidden)

[v . villenave]

On 2019/01/23 22:30:25, dak wrote:
> Shouldn't you consider preexisting octavation for sorting the pitches?

Duh.

> That looks like a mess.
> Don't you rather intend to sort the _notes_?

Sure. I figured in a chord, notes wouldn’t carry individual properties…
but they do, of course.

> list-set! here is unnecessary since ly:music-transpose modifies its
argument.

I can’t figure out how to make it work without resetting the
EventChord’s elements list. How would you proceed?

Thanks for the review!

V.

https://codereview.appspot.com/365840043/