Re: LYNX-DEV Comment parsing bug in lynx, and fix.

[Roger Hill]

On Mon, 18 Nov 1996, Brian Borowski wrote:

> 
> To whom it may concern:
> 
> I have found a bug (sort-of) in lynx's comment parsing code.
> For us blind people here, (like myself) we find lynx important and useful,
> and we couldn't figure out why some html was not being rendered at all.
> The problem was, after I did some checking around, that the comments in some
> people's pages consisted of  things like,
> <!--------------->
> Where there was a '<!--' followed by no blanks.  Lynx was
> not finding this, and seemed to be missing chunks of the document.
> 
> I noted, that in 'HTML.c' you were doing a strncmp(data, "<!--", 4), and
> then calling  LYFindEndOfComment after that.
> In 'LYFindEndOfComment' you were doing a strcmp(str, "<!--"),
> and I have changed this to  '(strncmp(str, "<!--", 4) to be consistant and
> also to find comments in strings that went on with no blanks.
> The fix has done wonders, and I have included a patch to the file
> 'LYCharUtils.c' below.
> 
> I could have erred in this thing, but I don't think so.
> Use patch to apply it.
Brian; I don't know if your patch is ok, but had you tried setting on 
minimal comment parsing, or historical comment parsing?? mapped to the ' 
and ` keys by default, I think.  Check the key help if necessary.

I think one or the other would fix your problem.
============================================================================
Roger Hill, M.I.S Manager, McEnearney Alstons (Barbados) Ltd
My opinions are my own, not my employer's.
Tel:246-230-9596        Fax:246-433-8365         E-mail: address@hidden
============================================================================

;
; To UNSUBSCRIBE:  Send a mail message to address@hidden
;                  with "unsubscribe lynx-dev" (without the
;                  quotation marks) on a line by itself.
;