Re: lynx-dev lynx2.8.2dev.24a.patch.gz

[Leonid Pauzner]

26-Apr-99 12:20 Ismael Cordeiro wrote:
> On Mon, 26 Apr 1999 address@hidden wrote:

>> Here's another try at LYSafeGets - please see if it does indeed fix
>> the cookie problem.

> It seems it does. I've run it on Solaris and FreeBSD and .lynx_cookies is
> preserved and I can access sites that use cookies for login.


Yes, the problem actually come from a wrong sizeof(buf) usage,
hope dev25 will be released soon and not so much lynx users
(ones who doesn't read lynx-dev) kill their cookie file due to a bug.



+* corrections/simplification of LYSafeGets(), and remove sizeof(buf) from
+  related code in LYCookie.c (analysis by KW) -TD
 1999-04-23 (2.8.2dev.24)
 * added overlooked WWW/Library/Implementation/makefile.in -TD
 1999-04-23 (2.8.2dev.23)

--- lynx2.8.2dev.24+/src/LYCookie.c     Fri Apr 23 11:06:34 1999
+++ lynx2.8.2dev.24a/src/LYCookie.c     Mon Apr 26 05:45:02 1999
@@ -1993,7 +1993,7 @@
         * cookie.
         */

-       while(buf[i] != '\n' && i < sizeof(buf)) {
+       while(buf[i] != '\n' && buf[i] != 0) {
            i++;
        }
        buf[i] = '\0';