Re: lynx-dev flickering upon first bookmark display

[Leonid Pauzner]

7-Dec-99 19:02 Klaus Weide wrote:
> On Sun, 5 Dec 1999 address@hidden wrote:

>> I'm not really following this discussion, so this is off topic.. but
>> the one case of flicker that *really* gets to me that I unsuccessfully tried
>> to figure out way back when when I was actually looking at the lynx code
>> (for that bookmark file manipulation code I hope to get back to some decade)
>> was this:
>>
>> I start up with my bookmark file as my start page, and I have multi-bookmarks
>> turned on.
>>
>> The bookmark file draws, THEN the whole screen redraws with:
>> Description: Default Bookmark File
>>    Filepath: lynx_bookmarks.html
>>
>> inserted at the beginning.

> I see... I never knew lynx did this.

> Well the double-drawing is only there with partial display on.

Hmm, that seems to be a chunk of code in mainloop under the case
NORMAL: when the first document loaded, it checks the page title
and than search a list of Multi-bookmarks for newdoc.address,
than goto try_again if the file recornized as a bookmark one.

Is it reliable to relay on title? If we can live without the title here
(which could not be found without loading the document), we could
probably move this chunk away from the case NORMAL on top of mainloop
near 'bookmark_start' staff to avoid double loading in this particular
case. Will it be a bug fix or lost the feature?

> (And if the bookmark file is short enough, my recent change discussed
> with Leonid should suppress it [when it works right]...)

> Using lynx locally (I haven't tried this with a remote one), with ncurses,
> I get a rather smooth redraw.  Actually ncurses doesn't really "redraw",
> it effectively and cleverly just scrolls the screen contents from the
> first refresh down to make space for the added lines.  Of course that
> would depend on what curses/slang library you use and on the terminal
> description.

>> It happens ONLY upon first starting up Lynx, and doesn't happen when 
>> switching
>> to other bookmark pages.  This is one of the kinds of cosmetic bugs that
>> are minor in the overall scheme of things, but drives me nuts.

> Working as it does by design, apparently.  Without partial display mode
> at least.

A referenced part of LYMainLoop.c starts with:

                    /*
                     *  If it's the first file and we're interactive,
                     *  check whether it's a bookmark file which was
                     *  not accessed via the -book switch. - FM
                     */
                    if (((first_file == TRUE) &&
                         (dump_output_immediately == FALSE) &&
                         !(newdoc.bookmark && *newdoc.bookmark)) &&
                        ((LYisLocalFile(newdoc.address) == TRUE) &&
                         !(strcmp((HText_getTitle() ? HText_getTitle() : ""),
                                  BOOKMARK_TITLE))) &&
                        (temp = HTParse(newdoc.address, "",
                                     PARSE_PATH+PARSE_PUNCTUATION)) != NULL) {