Re: About the last patch for private variables

[Paul Smith]

On Sun, 2009-07-19 at 03:55 +0200, Boris Kolpackov wrote:
> Hi Paul,
> 
> Paul D. Smith <address@hidden> writes:
> 
> > Also everyone please test this and make sure I didn't break anything.
> > Also I think that the new algorithm is not significantly slower than the
> > previous one but it's probably worth testing on any massive makefiles
> > you happen to have lying around (esp. on makefiles with lots of
> > variables assignments).
> 
> I just tested current CVS with my build system (which is quite
> complex) and noticed about ~30% slowdown compared to 3.81. Both
> were built with full optimization. Here are the results of the 
> three make-cvs runs:

Hi Boris; good to see you back!  There have been lots of changes since
3.81 so it's not clear that private variables are the problem.  It would
be great if you could use some kind of profiling (oprofile or gprof or
whatever) to get a clearer picture.

There's a serious issue with secondary expansion I've been fooling with
in the background, where we use double the memory needed for
prerequisite storing when secondary expansion is enabled.  I need to get
back to this.  Also, I think the string cache could be enhanced: right
now we have one hash for the strings and a separate one for files etc.
It seems like we should be able to combine these and save some effort.
This might mean we'd use multiple strcaches but that should be OK
because it's rare that you have variable names that are the same as file
names (for example).  Maybe that will wait for the next release though.

FYI, my family will be leaving me alone (just me and the dogs) for a
week starting Wednesday.  Although the "real world" project I've been
under water with for the last 8-10 (12?) months is still not _quite_ out
(August!  Definitely!) I'd like to try to spend some time that week
getting an RC1 for make 3.82.

Eli, I don't know what the status of the Windows port is ATM?

First order of business post-3.82: a new version control system!

-- 
-------------------------------------------------------------------------------
 Paul D. Smith <address@hidden>          Find some GNU make tips at:
 http://www.gnu.org                      http://make.mad-scientist.us
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist