[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: make ChangeLog NEWS main.c read.c variable.c va...
From: |
Paul Smith |
Subject: |
Re: make ChangeLog NEWS main.c read.c variable.c va... |
Date: |
Wed, 07 Oct 2009 14:19:41 -0400 |
On Wed, 2009-10-07 at 11:48 +0200, Boris Kolpackov wrote:
> > In the other change you made, I think either the code or comment here is
> > wrong:
> >
> > /* If the names are the same but ignore_mtimes are not equal, one of these
> > is an order-only prerequisite and one isn't. That means that we should
> > remove the one that isn't and keep the one that is. */
> >
> > if (!cmp && dx->ignore_mtime != dy->ignore_mtime)
> > dx->ignore_mtime = dy->ignore_mtime = 0;
>
> Yes, I meant to change this comment but forgot. That code is actually
> quite sneaky. It took me good half and hour to figure who changes
> the ignore_mtime. I went ahead and moved this upgrade logic to
> set_file_variables where it is more apparent.
Good stuff. Is there a regression test that exercises this? Seems like
something we're likely to break in the future if we're not checking it.
Cheers!
--
-------------------------------------------------------------------------------
Paul D. Smith <address@hidden> Find some GNU make tips at:
http://www.gnu.org http://make.mad-scientist.net
"Please remain calm...I may be mad, but I am a professional." --Mad Scientist