|
From: | Markus Schiltknecht |
Subject: | [Monotone-devel] cvs_import prepared revisions |
Date: | Fri, 20 Oct 2006 12:37:00 +0200 |
User-agent: | Thunderbird 1.5.0.7 (X11/20060927) |
Hi,I'm wondering why cvs_import (original and mine) feeds the revisions from the cluster_consumer to a vector of prepared revisions. And afterwards cluster_consumer::store_revisions() sends them all at once to the database. Why do we split tasks like that? Why can't we just skip the list of prepared_revisions and store them directly into the database in cluster_consumer::consume_cluster()?
Assuming write caching is enabled, I would suppose feeding them to the database in consume_cluster() would even be faster, because that would not split between CPU/RAM intensive and disk I/O intensive tasks but do them in parallel.
Can I remove the prepared_revision stuff safely or do I miss something? Regards Markus
[Prev in Thread] | Current Thread | [Next in Thread] |