monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [PATCH] _MTN/log pre-specified magic line quickie


From: Ben Walton
Subject: Re: [Monotone-devel] [PATCH] _MTN/log pre-specified magic line quickie
Date: Tue, 12 Dec 2006 09:07:34 -0500

I could resubmit with the po stuff reverted if that would help.  I
didn't realize that it wasn't useful to the diff when I sent it in.
This might be a good addition to the HACKING file?

Thanks
-Ben

On 12/12/06, Nathaniel J. Smith <address@hidden> wrote:
On Tue, Dec 12, 2006 at 08:08:58AM +0100, Thomas Keller wrote:
> Nathaniel J. Smith schrieb:
> > On Mon, Dec 11, 2006 at 11:34:23AM -0500, Ben Walton wrote:
> >> 2006-12-11  Ben Walton  <address@hidden>
> >>        * cmd_ws_commit.cc,
> >>        tests/commit_using__MTN_log/commit_log_modified_return.lua,
> >>        tests/commit_using__MTN_log/__driver__.lua:
> >>        Added the requirement that when _MTN/log is pre-specified by
> >>        the user, that the user remove a 'magic' line prior to the
> >>        commit being accepted.  Modified the units tests to verify this.
> >>        Updated texinfo to match this new behaviour.
> >
> > This looks good to me, but I don't really have a development
> > environment set up to commit from ATM, anyone else want to do it?
>
> Just checked that one in and pushed it. Is his earlier patch good to go
> as well?

Dunno, didn't wade through all the po stuff to figure out what it
looked like.  Your comments seemed reasonable.

-- Nathaniel


_______________________________________________
Monotone-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/monotone-devel



--
---------------------------------------------------------------------------------------------------------------------------
Ben Walton <address@hidden>

Unanswered questions are far less dangerous than unquestioned answers.
- The Roadside Pulpit
---------------------------------------------------------------------------------------------------------------------------




reply via email to

[Prev in Thread] Current Thread [Next in Thread]