Re: [Monotone-devel] [PATCH] _MTN/log pre-specified magic line quickie

[Nathaniel J. Smith]

On Mon, Dec 11, 2006 at 11:34:23AM -0500, Ben Walton wrote:
> 2006-12-11  Ben Walton  <address@hidden>
>        * cmd_ws_commit.cc,
>        tests/commit_using__MTN_log/commit_log_modified_return.lua,
>        tests/commit_using__MTN_log/__driver__.lua:
>        Added the requirement that when _MTN/log is pre-specified by
>        the user, that the user remove a 'magic' line prior to the
>        commit being accepted.  Modified the units tests to verify this.
>        Updated texinfo to match this new behaviour.

It looks like this broke a few tests; e.g. search for "FAIL" in
  http://venge.net:9000/linux_suse_9.3_x86_unopt/builds/50/test/0
They mostly look like the tests need updating, rather than that the
actual code is broken.

I'm not sure how annoying it will be to fix some of them; I almost
wonder if the actual ******DELETE THIS LINE***** handling should move
to be more of the hook's responsibility?  (Like we tell the hook when
we think some extra confirmation might be needed, and the hook tells
us when it thinks that that extra confirmation has been given.)  Just
a random thought, though.

-- Nathaniel