monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [PATCH] _MTN/log pre-specified magic line quickie


From: Ben Walton
Subject: Re: [Monotone-devel] [PATCH] _MTN/log pre-specified magic line quickie
Date: Mon, 18 Dec 2006 11:46:54 -0500

Well, there's something to think about.  What about a mtn do_patch or
something similar that takes a .diff/.patch and applies it, adding
unknown files afterwards?

The problem I see with that is that you may add other files
inadvertently if you had already introduced new files...?

Might be worth some thought though, as patch -p1 < somepatch.diff is a
fairly common thing in a distributed project...

Thoughts?
-Ben

On 12/18/06, Thomas Keller <address@hidden> wrote:
Ben Walton schrieb:
> I believe the attached patch fixes the broken test cases for the magic
> line patch.

I applied that and added a missing file (commit_log_modified_return.lua)
which contents where guessable =)

> It looks like the wrong mkdir patch may have been applied to the tree
> also, causing that test to fail.  I submitted two attempts at that
> patch (the first not including the tests...before morning coffee).
> The second one included the tests and should work.

Sorry, this was my fault. I should really configure alias mtnci="mtn add
--unknown && mtn ci" sometime in the future =)

Thomas.

--
ICQ: 85945241 | SIP: 1-747-027-0392 | http://www.thomaskeller.biz
> Guitone, a frontend for monotone: http://guitone.berlios.de
> Music lyrics and more: http://musicmademe.com


_______________________________________________
Monotone-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/monotone-devel



--
---------------------------------------------------------------------------------------------------------------------------
Ben Walton <address@hidden>

Unanswered questions are far less dangerous than unquestioned answers.
- The Roadside Pulpit
---------------------------------------------------------------------------------------------------------------------------




reply via email to

[Prev in Thread] Current Thread [Next in Thread]