Re: [Monotone-devel] basic_io not binary transparent?

[Christof Petig]

Hi Nathaniel,

Nathaniel J. Smith schrieb:
>> -    lookahead = *curr;
>> +    lookahead = *curr & 0xff;
> 
> Using:
>   lookahead = widen<int,char>(*curr);
> is better (I guess maybe with a comment?  this is exactly the sort of
> situation widen<> is designed for, though), and this patch appears to
> use tabs instead of spaces for indentation, but yeah, fine to commit.

I added a comment and used widen<unsigned int,char> since
widen<int,char> still does sign extension.

Yours
  Christof

PS: I _shall_ not need funding for the summit. IMHO if fully apprenticed
university engineers with a paid job ask for funding something is going
wrong indead. OTOH paying the flight just because of a hobby hurts my
family's holiday budget, too.

signature.asc
Description: OpenPGP digital signature