monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] bugreport monotone


From: Stephen Leake
Subject: Re: [Monotone-devel] bugreport monotone
Date: Sat, 27 Sep 2008 16:10:36 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (windows-nt)

"Zack Weinberg" <address@hidden> writes:

> On Sat, Sep 27, 2008 at 11:29 AM, Stephen Leake
> <address@hidden> wrote:
>>> Hrm... any objectives against checking in this patch (netxx upstream is
>>> dead, right)?
>>
>> ETIMEDOUT isn't defined in MinGW. The WIN32 timeout case is apparently
>> handled by WSAETIMEDOUT.
>
> bleah
>
>> I've checked in a patch:
>>
>> #if not defined(WIN32)
>>                case ETIMEDOUT:
>> #endif
>
> Please make that
>
> #ifdef ETIMEDOUT
>     case ETIMEDOUT:
> #endif

Ok, done.

> -- the E* constants are guaranteed since C89 to be macros, so this is
> safe in general.

Does that mean the gcc MinGW compiler is not compliant with C89?
That's surprising.

-- 
-- Stephe




reply via email to

[Prev in Thread] Current Thread [Next in Thread]