[Monotone-devel] Re: nvm.dates

[Lapo Luchini]

Markus Wanner wrote:
> Hi,
> 
> thank you for your review.
> 
> Stephen Leake wrote:
>> So I think keeping date unsigned is ok, but please document this
>> rationale in dates.hh.
> 
> Okay, will do.
> 
> One reason for using unsigned is that a single $DATE < $MAX is
> sufficient in valid(), whereas with a signed integer we'd have two
> comparisons.

Well the question is: should we allow commits (or rather, imports) to
have a date before year 1970?
(personally I'd use signed for the sake of it, but won't really ever
notice, as I won't be importing anything from the 60s anyway ^_^)

-- 
Lapo Luchini - http://lapo.it/