Re: [Monotone-devel] mtn status speed

[Jack Lloyd]

On Mon, Dec 08, 2008 at 09:06:10PM -0800, Tony Tung wrote:

>  I suspect it is calculating the status for all the files in the
> workspace, and *then* filtering out just the files in the command
> line.

I could not say for certain, but from looking at the code implementing
the status command it appears to respect the masks provided on the
command line. Tracking the open syscalls using strace
(http://linux.die.net/man/1/strace) also seemed to confirm this, mtn
didn't open or stat any files outside of the paths specified.

One odd thing I noticed is that mtn will stat each file twice,
right in a row.

stat("rcs_file.hh", {st_mode=S_IFREG|0600, st_size=1610, ...}) = 0
stat("rcs_file.hh", {st_mode=S_IFREG|0600, st_size=1610, ...}) = 0
open("rcs_file.hh", O_RDONLY)           = 4

which seems a little odd, but shouldn't be a huge performance issue.

-Jack