[Monotone-devel] Possible Minor Bug With Automate Stdio I/F select...

[Anthony Edward Cooper]

   Hi all :-),

   Just noticed that when you do something like:

$ mtn automate stdio
l6:select2:x:e
mtn: warning: unknown selector type: x
0:0:m:32768:0005a23e30a9c2d3024d94773eec433bf9acb770
000645e7c050166ae0aba4d8ff3320f016da68ea
0006d609f3fe96a8fe3375d26d1a2de0bc93e882
.
.
.

   The warning message comes up as free format text on stderr. Whereas 
I would have expected the error message to be handled the same way as in 
this example:

$ mtn automate stdio
l6:select22:l:2009-02-22Tz16:47:00e
0:2:l:82:misuse: selector '2009-02-22Tz16:47:00' is not a valid date 
(2009-02-22Tz16:47:00)

Seems a simple enough change:

#
# old_revision [6c12b62baa30a1abbe32e8d0463337b8a03eb8af]
#
# patch "selectors.cc"
#  from [91d924b52e55b60329cba63adac1af6d874014d0]
#    to [02aa7dcfb35cd604d3917b903f7effee906fdf6f]
#
============================================================
--- selectors.cc        91d924b52e55b60329cba63adac1af6d874014d0
+++ selectors.cc        02aa7dcfb35cd604d3917b903f7effee906fdf6f
@@ -117,7 +117,7 @@ decode_selector(project_t & project,
          type = sel_update;
          break;
        default:
-          W(F("unknown selector type: %c") % sel[0]);
+          E(false, origin::user, F("unknown selector type: %c") % sel[0]);
          break;
        }
      sel.erase(0,2);

I can submit to head if you want..../agree with the proposed change.

MTIA,

Tony.