Re: [Monotone-devel] checking for stray characters when parsing dates

[Stephen Leake]

Derek Scherger <address@hidden> writes:

> I made a slight change to the date parsing code
> in ff193643616656b62a465d043676e3faf83418b7 to re-add the check for stray
> characters following the date that aren't matched by the specified format. I
> also added a simple check for this condition to the associated unit tests to
> make it clear what the problem is.
>
> I assume that this was removed inadvertently
> in a8147b11ee2d598835a4e1cec0e9782e4388e679 when the fixes for the lack of
> strptime (or anything seemingly equivalent) in win32 went in.
>
> Thanks for dealing with the win32 side of this Stephen, 

You're welcome.

> please let me know if that check was removed intentionally.

No, I did not realize that check was important for this function.

I had changed it to return a bool to allow checking to see if date
parsing was ok; now that is handled at a higher level.

I just noticed there is a "HAVE_STRPTIME" in config.h.in, which is not
defined on Debian. I guess we can just ignore that, but it is odd.

-- 
-- Stephe