monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] --use-transport-auth


From: Timothy Brownawell
Subject: Re: [Monotone-devel] --use-transport-auth
Date: Sat, 12 Jun 2010 14:45:37 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4

On 06/12/2010 02:27 AM, Thomas Keller wrote:

Hi!

While refactoring in the the netsync connection info branch I stumbled
upon the use_transport_auth option, which is by default true and
eventually gets set to false in case --no-transport-auth is set.

However, this option should probably not work at all, because we
overwrite the user's choice in cmd_netsync.cc everywhere like this:

   app.opts.use_transport_auth = \
     app.lua.hook_use_transport_auth(info.client.uri);
   if (app.opts.use_transport_auth)
     {
       find_key(app.opts, db, keys, app.lua, project, info, true);
     }

Now this could be the reason why bug #28805 is open for so long and why
people claimed they need an --anonymous option for netsync, which - with
its current implementation - just disables the key loading a little bit
later after use_transport_auth has wrongly evaluated to true...

No, --no-transport-auth is only accepted by 'serve' and it doesn't get reset there. It's used to turn off key checking and the hmac when using file:// or ssh:// sync where the client spawns a new server for the connection.

The problem is "-k ''" not working in some cases (automate pull, I think). It does work from the command line, say to force monotone to not use the workspace key setting.

--
Timothy

Free public monotone hosting: http://mtn-host.prjek.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]