[Monotone-devel] --use-transport-auth

[Thomas Keller]

Hi!

While refactoring in the the netsync connection info branch I stumbled
upon the use_transport_auth option, which is by default true and
eventually gets set to false in case --no-transport-auth is set.

However, this option should probably not work at all, because we
overwrite the user's choice in cmd_netsync.cc everywhere like this:

  app.opts.use_transport_auth = \
    app.lua.hook_use_transport_auth(info.client.uri);
  if (app.opts.use_transport_auth)
    {
      find_key(app.opts, db, keys, app.lua, project, info, true);
    }

Now this could be the reason why bug #28805 is open for so long and why
people claimed they need an --anonymous option for netsync, which - with
its current implementation - just disables the key loading a little bit
later after use_transport_auth has wrongly evaluated to true...

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature